Improve completion of service scale args#5968
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 26, 2025
Merged
Conversation
Signed-off-by: albers <github@albersweb.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5968 +/- ##
==========================================
- Coverage 59.09% 59.08% -0.02%
==========================================
Files 354 354
Lines 29733 29741 +8
==========================================
Hits 17572 17572
- Misses 11191 11199 +8
Partials 970 970 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@thaJeztah The test failures seem not to be related to my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PR:
docker service scale <TAB>completes service names, followed by a space. This tempts the user to enter a number, producing illegal syntax, e.g.docker service scale nginx 2.With this PR:
docker service scale <TAB>completes service names with "=" appended and no trailing space. This guides the user to the correct argument syntax, e.g.docker service scale nginx=2.The legacy completion worked like this.